`/ip`, riptide undead fix, disabled commands in config

commandgeek / GeekSMP

GeekSMP Plugin

Other

13 stars 4 forks source link

`/ip`, riptide undead fix, disabled commands in config #82

Closed Lianecx closed 2 years ago

Lianecx commented 2 years ago

Description

Tridents now work properly for undeads (no damage anymore) Disabled commands can now be set in the config.yml (settings.disabled-commands) /ip command added (shows public ip address of player)

Motivation and Context

fixes #54 fixes #77 fixes #74

How Has This Been Tested?

Local hosted server MC Version 1.17.1, Paper

Executed disabled commands
Tried to riptide with a trident as an undead and revived
Executed /ip command for myself and another player who joined

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.

Lianecx commented 2 years ago

Is the /ip response message fine or should it be something else?

Currently it's: "The IP of Lianecx is 127.0.0.1"

srnyx commented 2 years ago

Is the /ip response message fine or should it be something else?

Currently it's: "The IP of Lianecx is 127.0.0.1"

Could you make it configurable in messages.yml? And what are the changes you made to /afk? And what does this do exactly: replace("minecraft:", "")? Cause commands can be run using /minecraft: even if the command without /minecraft: is disabled I'm pretty sure.

Lianecx commented 2 years ago

Sure, ill make it work with messages, I removed unnecessary code in /afk. Both if statements that i removed are already there, above the cooldown checker I replace the "/" and the "minecraft:" (if it exists) of the command that the user types so you only have to specify "help" in the config and not both "help" AND "minecraft:help"

Lianecx commented 2 years ago

There are no command response messages inside messages.yml

Lianecx commented 2 years ago

Under which category should i add the message

srnyx commented 2 years ago

I replace the "/" and the "minecraft:" (if it exists) of the command that the user types so you only have to specify "help" in the config and not both "help" AND "minecraft:help"

That may cause some issues though. The plugin overwrites the /tp command which means if we wanna use selectors or the vanilla command we type /minecraft:tp.

Under which category should i add the message

Information Messages