Update proximity speed & imports, fix #6 and `/rsmp` tab

commandgeek / GeekSMP

GeekSMP Plugin

Other

13 stars 4 forks source link

Update proximity speed & imports, fix #6 and `/rsmp` tab #86

Closed srnyx closed 2 years ago

srnyx commented 2 years ago

Description

Proximity speed for undeads will now be given when another player is not a radius of 50 blocks (instead of 100) and will only get speed 3 instead of 5.
Revive sound will now only be heard by the killer and the killed.
/rsmp will no longer break placeholders in tab

Co-authored by: @DWAA1660

Motivation and Context

Fixes #6

How Has This Been Tested?

Tested on a test server on Java 1.17.1, Paper

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.

Lianecx commented 2 years ago

But why only speed 3. I see no reason for that. They cant even use elytra anymore

srnyx commented 2 years ago

But why only speed 3. I see no reason for that. They cant even use elytra anymore

Zombies are supposed to be slow. It makes no sense for them to be faster than normal speed... Making it speed 3 cancels out their slowness 3 which means they walk normally without other players near them.

Lianecx commented 2 years ago

They are supposed to be faster thab normal players. They should be able to get to other players quickly

srnyx commented 2 years ago

They are supposed to be faster thab normal players. They should be able to get to other players quickly

No, they aren't... they are undead... The last time I checked bones (skeletons) and brain moosh (zombies) don't move faster than muscles and a functioning brain.

DWAA1660 commented 2 years ago

nothing changed with skeles right

Lianecx commented 2 years ago

Skeles also only have speed 3 now

srnyx commented 2 years ago

Skeles also only have speed 3 now

Yeah, but that's still faster than normal players. The only noticeable difference is with zombies. But they still run faster than usual.

srnyx commented 2 years ago

Since the imports change lists basically every file as changed, here's the important changes I made: Setup.java: listeners/DeathListener.java: listeners/MoveListener.java: