commandiron / WheelPickerCompose

Add Wheel Date - Time Picker in Android Jetpack Compose.
Apache License 2.0
444 stars 54 forks source link

Support for AM/PM #7

Closed SamPlusPlus closed 1 year ago

SamPlusPlus commented 1 year ago

I would like to support AM and PM as well as 24-hour format. Is this something you are considering?

commandiron commented 1 year ago

hey Sam thanks for your feedback. AM PM support has crossed my mind too, but this feature completely changes the layout because the user must specify whether the selected time is AM or PM so that snappedDate is given correctly. AM/PM button should be added so that this can be done. I will work on it as soon as possible. Thanks again.

commandiron commented 1 year ago

hi, i add AM/PM support, this release has this option as timeFormat param. in time picker, however with date picker AM/PM time picker not working correctly, i will solve this problem later and release another version later. Thanks.

SamPlusPlus commented 1 year ago

@commandiron I can try and take a look at this and give some feedback if that would be helpful. I look forward to the future release. Ty for taking a look at this!

On Tue, Nov 29, 2022 at 1:04 PM Emir Demirli @.***> wrote:

hi, i add AM/PM support, this https://github.com/commandiron/WheelPickerCompose/releases/tag/1.1.4 release has this option as timeFormat param. in time picker, however with date picker AM/PM time picker not working correctly, i will solve this problem later and release another version later. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/commandiron/WheelPickerCompose/issues/7#issuecomment-1331083616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFUYKLW5MP2NIKUCL4CDS3WKZATDANCNFSM6AAAAAASHLUJSM . You are receiving this because you authored the thread.Message ID: @.***>