Prototype Support

[GoogleCodeExporter]

I was happy to find this project, but needed a Prototype-compatible version.  
So, I downloaded the 1.2 ZIP file and made the necessary changes.  Attached is 
a patch file that replicates those changes, summarized here:

css/openid.css
Turns off the CSS entry hiding the openid_choice node.  Prototype, at least, 
can't override a 'display:none;' stylesheet entry.

demo-prototype.html
Retooling of demo.html to work with Prototype.

generate-sprite.rb
Retooling of generate-sprite.js to work with Ruby on a Linux or Mac system.  
Dependencies are listed in the file.

js/openid-prototype.js
Retooling of js/openid-jquery.js to work with Prototype.  I'm not a Prototype 
guru, so there's probably room for optimization of the code to be as 
streamlined as the jquery version.

js/prototype.js
Version 1.7_rc2 of the Prototype library.

I tried to minimize any changes to the existing code, only touching the CSS 
file because I had to.  However, If you distribute both versions together 
(and...why not?), it would probably be best to remove the "-jquery" component 
of the language-specific javascript filenames, as those aren't really 
library-dependent.

Anyway, hope this helps,
-Jonathan

Original issue reported on code.google.com by JesterChicago@gmail.com on 17 Nov 2010 at 2:15

Attachments:

• openid-selector.patch

[GoogleCodeExporter]

thanks, I will integrate this into trunk.

about
"However, If you distribute both versions together (and...why not?), it would 
probably be best to remove the "-jquery" component of the language-specific 
javascript filenames, as those aren't really library-dependent."

Yes, next version of openid-selector will ship jquery, mootools and prototype 
versions together and -jquery component of language-specific file names will be 
removed.

Original comment by andriy.gerasika on 26 Nov 2010 at 11:01

[GoogleCodeExporter]

done
http://openid-selector.googlecode.com/svn/trunk/demo-prototype.html

about Prototype not able to override a 'display:none;' stylesheet entry:
I have bypassed this w/ following code:
--
$('openid_choice').setStyle({
display: 'block'
});
--
is this ok?

Original comment by andriy.gerasika on 26 Nov 2010 at 12:05

• Changed state: Fixed

[GoogleCodeExporter]

Yes, that code snippet seems to do the trick on my end as well.  Thanks.

Original comment by JesterChicago@gmail.com on 26 Nov 2010 at 1:27