search

commandprompt / redmine_involvement_filter

A plugin to filter out issues in which the current user is involved.
12 stars 3 forks source link

Plugin breaks timesheet view #4

Open nelo-digitalagentur opened 11 years ago

nelo-digitalagentur commented 11 years ago

With the involvement filter plugin installed the timesheet view is broken. Internal error message appears and the log file says:

Completed 304 Not Modified in 11ms (ActiveRecord: 0.9ms) Started GET "/redmine/projects/test2/issues/1480/time_entries" for 84.171.107.243 at Thu May 09 10:16:14 +0200 2013 Processing by TimelogController#index as HTML Parameters: {"issue_id"=>"1480", "project_id"=>"test2"} Current user: netzloesungen (id=1) Completed 500 Internal Server Error in 30ms

TypeError (can't dup NilClass): app/models/query.rb:321:in add_filter' app/models/time_entry_query.rb:35:ininitialize' app/models/query.rb:211:in new' app/models/query.rb:211:inbuild_from_params' app/controllers/timelog_controller.rb:45:in `index'

Information about my environment:

Environment: Redmine version 2.3.0.stable.11715 Ruby version 1.8.7 (x86_64-linux) Rails version 3.2.13 Environment production Database adapter MySQL Redmine plugins: clipboard_image_paste 1.6a due_date_reminder 0.3.2 extended_fields 0.2.1 redmine_banner 0.0.8 redmine_close_button 0.0.8 redmine_favourite_projects 0.6.2 redmine_issue_templates 0.0.5 redmine_lightbox 0.0.1 redmine_nelo_multipledownload 0.1 redmine_people 0.1.6 redmine_pretend 0.0.3 redmine_project_responsibility 0.1 redmine_silverstar 0.0.1 redmine_silverutils 0.1 redmine_timesheet_plugin 0.7.0 redmine_workload 0.1.0

nelo-digitalagentur commented 11 years ago

Any idea how this could be solved? Again i like to offer some "beer" to you to solve this. Please let me know if we can agree on an amount.

a1exsh commented 11 years ago

Sorry for not getting to this earlier, but it works for me on Redmine-2.2.4, Rails-3.2.13, Ruby-1.9.3.

Are you sure it's not any of the other plugins you have installed? Does it work if you remove involvement plugin and try again?

nelo-digitalagentur commented 11 years ago

Yes, it works when i uninstall the plugin.

May be its something thats treated different in redmine 2.3?

ashcmd commented 11 years ago

Andreas Hartmann notifications@github.com writes:

Yes, it works when i uninstall the plugin.

May be its something thats treated different in redmine 2.3?

Yeah, it looks like there's new class IssueQuery we should be patching instead of Query in 2.3.

Could you please try applying the attached patch and let me know if it fixes the issue for you?

nelo-digitalagentur commented 11 years ago

I am sorry, but where can i find the patch?

a1exsh commented 11 years ago

Hm, attachments don't seem to work at all. Please try this commit: 624092ab667867ba4a59dce0fa42d0037c830a3f

nelo-digitalagentur commented 11 years ago

Hey, that did the trick! Again i owe you a beer. Where is your donate button?

Thanks and kind regards!

a1exsh commented 11 years ago

On Wed, May 29, 2013 at 6:37 PM, Andreas Hartmann notifications@github.comwrote:

Hey, that did the trick! Again i owe you a beer. Where is your donate button?

Oh, glad to hear that. You're welcome, I'm doing this for my employer, so I'll check to see if we accept donations of booze ;-)

Alex

dvader commented 10 years ago

This worked for me too. Can we merge this into master?

xaionaro commented 10 years ago

Didn't work for me. I've tried the branch "redmine-2.3" (with the bugfix already), but it's still:

Completed 500 Internal Server Error in 1329.9ms

TypeError (can't dup NilClass):
  app/models/query.rb:220:in `build_from_params'
  app/models/issue_query.rb:119:in `build_from_params'
  app/helpers/queries_helper.rb:197:in `retrieve_query'
  app/controllers/issues_controller.rb:56:in `index'

UPD: But my issue is about page https://redmine.someorganisation.org/projects/someproject/issues. Seems that I commented on wrong issue. I'll create a new one.