search

commenthol / date-holidays-parser

parser for worldwide holidays
ISC License
46 stars 23 forks source link

isHoliday does not have the correct typescript definition for return type #12

Closed germain-receeve closed 5 years ago

germain-receeve commented 5 years ago

Typescript definition: Holidays.isHoliday(date: Date): Holidays.Holiday In reality it should be either Holidays.isHoliday(date: Date): Holidays.Holiday | boolean or Holidays.isHoliday(date: Date): Holidays.Holiday | false

germain-receeve commented 5 years ago

Sorry wrong Repo, recreating in the right one. https://github.com/commenthol/date-holidays/issues/117