search

commenthol / date-holidays-parser

parser for worldwide holidays
ISC License
46 stars 22 forks source link

Return rule in getHolidays #16

Closed stefanvanherwijnen closed 4 years ago

stefanvanherwijnen commented 4 years ago

This changes getHolidays such that the rule is returned alongside the date and name.

Use case: I need to make a translatable selection input of holidays. The rule is the only constant when years and language vary. This seemed to be the easiest fix.

stefanvanherwijnen commented 4 years ago

@commenthol Any thoughts on this?

commenthol commented 4 years ago

@stefanvanherwijnen Thanks for your PR. Let's try to progress here. I need to combine the things with the data-set at date-holidays mainly for the tests.

stefanvanherwijnen commented 4 years ago

Thanks, let me know if I need to add anything to this PR.

commenthol commented 4 years ago

@stefanvanherwijnen date-holidays was published in v1.6.0 with your requested changes. Thanks and have fun with it.