search

commenthol / date-holidays-parser

parser for worldwide holidays
ISC License
46 stars 22 forks source link

feat: replace moment-timezone with luxon #48

Open pzien opened 2 years ago

commenthol commented 2 years ago

Hi @pzien, Can you please run your parser changes with the data set from date-holidays? I do get some errors there related to solstice and equinox. Would be nice if you could add some test cases here.

pzien commented 2 years ago

I will do that! Thanks for feedback.

mcshaz commented 1 year ago

Can I please bump this request (pending for 7 months at the time of writing)- moving to a modern esm library which uses/extends Intl.DateTime (as opposed to importing moment and moment-timezone) will result in smaller package sizes due to both tree shaking at the build stage and also not duplicating functionality in modern ES engines.