New Zealand Holidays

[mrfrase3]

I've just had a bug ticket come across from New Zealand, where they have 16 regions and one island with "regional powers", but only 12 (including the island) have regional holidays and there are only 12 regions in the data for NZ.

The missing regions with no regional holidays are:

• WKO - Waikato,
• BOP - Bay of Plenty
• GIS - Gisborne
• MWT - Manawatu-Wanganui
• TAS - Tasman

Is this correct? Are regions without holidays left out intentionally, or should I make a PR to add the missing regions with no dates listed?

https://www.govt.nz/browse/work/public-holidays-and-work/public-holidays-and-anniversary-dates/ https://en.wikipedia.org/wiki/Regions_of_New_Zealand#List_of_regions

[commenthol]

Hi @mrfrase3, Feel free to complete the missing regions. Your PR is very welcome.

[mrfrase3]

Looks like it's even more complicated, where some of the missing regions actually use other regions holidays, even worse, the observance days occur when the agricultural show is on. Even even worse, because the holidays are celebrated on a since-abandoned regional division map, some districts celebrate holidays from other parent regions. :expressionless:

https://en.wikipedia.org/wiki/Public_holidays_in_New_Zealand#Provincial_anniversary_days

[mrfrase3]

There is also the new national holiday, Matariki, that should start next year given that the legislation passes, which it most likely will given the labour party's overwhelming majority.

It is based on a lunar calendar, which a committee has used to recommend dates for the next 30 years: https://www.mbie.govt.nz/assets/matariki-dates-2022-to-2052-matariki-advisory-group.pdf

[commenthol]

The Maori lunar calendar looks very interesting. But implementing a calendar for one holiday (which also requires human interaction) is maybe not the way to go. Therefore I'd propose to add this Holiday as a series:

'2022-06-24':
  name:
    en: Matariki
'2023-07-14':
  name:
    en: Matariki
'2024-06-28':
  name:
    en: Matariki
'2025-06-20':
  name:
    en: Matariki
'2026-07-10':
  name:
    en: Matariki
'2027-06-25':
  name:
    en: Matariki
'2028-07-14':
  name:
    en: Matariki
'2029-07-06':
  name:
    en: Matariki
'2030-06-21':
  name:
    en: Matariki
'2031-07-11':
  name:
    en: Matariki
'2032-07-02':
  name:
    en: Matariki
'2033-06-24':
  name:
    en: Matariki
'2034-07-07':
  name:
    en: Matariki
'2035-06-29':
  name:
    en: Matariki
'2036-07-21':
  name:
    en: Matariki
'2037-07-10':
  name:
    en: Matariki
'2038-06-25':
  name:
    en: Matariki
'2039-07-15':
  name:
    en: Matariki
'2040-07-06':
  name:
    en: Matariki
'2041-07-19':
  name:
    en: Matariki
'2042-07-11':
  name:
    en: Matariki
'2043-07-03':
  name:
    en: Matariki
'2044-06-24':
  name:
    en: Matariki
'2045-07-07':
  name:
    en: Matariki
'2046-06-29':
  name:
    en: Matariki
'2047-07-19':
  name:
    en: Matariki
'2048-07-03':
  name:
    en: Matariki
'2049-06-25':
  name:
    en: Matariki
'2050-07-15':
  name:
    en: Matariki
'2051-06-30':
  name:
    en: Matariki
'2052-06-21':
  name:
    en: Matariki

In case that there are overlapping regions for one or the other holiday you may want to add that as a note. See https://github.com/commenthol/date-holidays/blob/01d95c6a508b499f7ecea4d229bfd3b406dda912/data/countries/CH.yaml#L320-L321

[commenthol]

Hi @mrfrase3, Can you please take a look at #291? If this fixes the issue please let me know.

[mrfrase3]

Looks like it fixed the issue of missing regions and the new national holiday is fixed, although not their regional holidays. E.g. bay of plenty has the same regional holiday date as Auckland.

I started trying to make sense of it all in this Google doc, then realised the only way to get super accurate data would be to crawl through local government websites or even email them to confirm. Suffice to say that work lowered the priority of this after the scope blew out, maybe you can make use of it.

https://docs.google.com/spreadsheets/d/1W-Ss3cV8XCSWEvg5j_T0Jo0VYTPCd0Kploj071pHlqU/edit?usp=drivesdk

[commenthol]

Hi @mrfrase3, Thanks for the Google doc, that helped with understanding the regional structure inside the provinces. Now all provinces contain a Provincial anniversary day.

NZ-CAN-S South Canterbury was renamed to NZ-CAN-Timaru. NZ-WTC-Buller district was added to change here to Nelson Provincial Anniversary Day. Please advise if better naming on districts are desired/ appropriate.

It would be interesting if you could solve the puzzle with:

• NZ-NSN: "parts of North Canterbury" -> Do we find the region/ district names?
• NZ-WTC: "Varies (outside Greymouth)" -> Region and Date affected?

[commenthol]

Hi @mrfrase3, Do you have any updates on my above remarks? Did you have some time to review the changes made in PR#291? I would like to prepare for merging the PR as I think things have improved there.

[mrfrase3]

Hey @commenthol

Sorry, I missed the November message. The current PR is definitely an improvement, and it's probably important to ship the new holiday.

I think the further sub-regional issues are a bit minor and, after more pondering, can be solved in a later PR.