search

commenthol / date-holidays

worldwide holidays
https://commenthol.github.io/date-holidays/
Other
923 stars 239 forks source link

feat(IL): New country Israel #296

Closed commenthol closed 2 years ago

commenthol commented 2 years ago

Tries to solve #36.

The test will fail currently as a fix in the parser is needed to solve an issue with Hebrew to Gregorian Calendar conversion.

oprogramador commented 2 years ago

We need to fix tests before merging.

commenthol commented 2 years ago

Hi @oprogramador, Thanks for your review. I use a "custom" calendar calculated from hebcal. I suspect that the conversion which is done there needs some fixing. Currently I don't have the time to look into this topic, but I won't forget about it.

commenthol commented 2 years ago

fix needs parser update for passing the tests see https://github.com/commenthol/date-holidays-parser/pull/37

oprogramador commented 2 years ago

fix needs parser update for passing the tests see commenthol/date-holidays-parser#37

Thanks for https://github.com/commenthol/date-holidays-parser/pull/37. I left some comments there and I also see a build failing.

commenthol commented 2 years ago

Hi @oprogramador, The parser is now up-to-date with the required fixes. Tests are passing as well with the different node versions. Maybe you'd like to review the changes made on the holiday rules. Thanks

oprogramador commented 2 years ago

Hi @oprogramador, The parser is now up-to-date with the required fixes. Tests are passing as well with the different node versions. Maybe you'd like to review the changes made on the holiday rules. Thanks

Thanks. I left some new comments on https://github.com/commenthol/date-holidays-parser/pull/37 after it had been merged and I opened two my PRs: https://github.com/commenthol/date-holidays-parser/pull/38 & https://github.com/commenthol/date-holidays-parser/pull/39.