commenthol
commented
2 years ago Hi @svict4, My questions:
- Are CX and CC considered being states/ regions in AU?
- Are holidays in CX and CC mainly following the holidays in AU?
From what I see is that they are considerable different. You may take a look at FR and the assigned oversees territories like YT or MQ. Please bear in mind that these territories strictly follow the FR holidays with one exception.
Taking a deeper look into your draft PR you can see the amount of disable rules (the ones with : false) which IMHO is not necessary if staying with the NF.yaml
I'd like to avoid complicating things. As this project is mainly about holidays following geopolitical assignments I suggest to keep the structure as is and document the holidays in their respective country code (Norfolk in NF, Cocos in CC, ...).
If you still want to integrate them in AU use the _days reference.
Hey was wondering if it was worth moving Christmas Island and Cocos Islands to the Australia file, just like Norfolk Island.
Despite them having their own alpha-2 country codes, they aren't countries and are just external territories of Australia. Their public holidays are by proclamation from an Australia-appointed administrator.