First off, congrats on the amazing library! A great approach on implementing a holidays library. I learned a lot by looking at the yaml files.
As we are using this library in a pet/learning project, I saw some issues with the Slovenian holidays. For the most part, nothing huge, but there is one day, marked as a public holiday that is not correct, so we need to hardcode some rules to fix this issue. But that is not optimal and also does not help others, so I made a PR.
Changes:
Primož Trubar day is changed from public to observance
This was never a public holiday. And we have the Reformation Day on the 31th October to mark the contribution of protestantst to the Slovenian language and culture
Dan vstaje is removed. There is no such holiday, since 1991. I suppose the confusion is due to the fact that the Wikipedia page mentions this day, but says that it was a public holiday until 1991. So basically until we got our independence.
I capitalised the names, as we usually write the intial letter with a uppercase, like our siblin languages Croatian, Serbian etc
Updated Slovenian and english names with the official translations from the legislation and/or the government's english pages
First off, congrats on the amazing library! A great approach on implementing a holidays library. I learned a lot by looking at the
yamlfiles.As we are using this library in a pet/learning project, I saw some issues with the Slovenian holidays. For the most part, nothing huge, but there is one day, marked as a
publicholiday that is not correct, so we need to hardcode some rules to fix this issue. But that is not optimal and also does not help others, so I made a PR.Changes:
Primož Trubar dayis changed frompublictoobservanceThis was never a public holiday. And we have theReformation Dayon the 31th October to mark the contribution of protestantst to the Slovenian language and cultureSlovenian Sports Day, aobservancetype, added in 2020 (https://www.uradni-list.si/glasilo-uradni-list-rs/vsebina/2020-01-1627?sop=2020-01-1627) that came into law on the 3rd of July 2020 (published on the 18th of June + 15 days of vacatio legis)Dan vstajeis removed. There is no such holiday, since 1991. I suppose the confusion is due to the fact that the Wikipedia page mentions this day, but says that it was a public holiday until 1991. So basically until we got our independence.Sources: