search

commenthol / date-holidays

worldwide holidays
https://commenthol.github.io/date-holidays/
Other
911 stars 236 forks source link

Warning when building in angular 14 project #348

Closed Gillardo closed 2 years ago

Gillardo commented 2 years ago

This was ok when i was using angular 13 which i believe targets es2018, but since updating i am getting these errors.

image

Here is my tsconfig

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "downlevelIteration": true,
    "experimentalDecorators": true,
    "moduleResolution": "node",
    "importHelpers": true,
    "target": "es2020",
    "module": "es2020",
    "lib": [
      "es2018",
      "dom"
    ],
  }
}
commenthol commented 2 years ago

Hi @Gillardo, As said this project offers both ESM and CJS via package.json exports. If you think the issue is unrelated to your project setup, please provide a fix via a PR.

Gillardo commented 2 years ago

Sorry but i do not think this is correct. It also states this on the deepmerge github https://github.com/TehShrike/deepmerge/issues/250

Which as i stated, was one of the errors when using your library image