search

commenthol / date-holidays

worldwide holidays
https://commenthol.github.io/date-holidays/
Other
906 stars 234 forks source link

11-15 is not Holidy in Japan ( Seven-Five-Three Festival, Shichigosan) #381

Closed usaribbon closed 1 year ago

usaribbon commented 1 year ago

Dear date-holidays's developpers,

Hi, I like this module and thanks a lot to develop this.

I use this module in my project and notice that 11-15 is ordinary day. However, this module recognizes the day as a holiday.

Could you modify 11-15 of JP?

Best regards, Minami

commenthol commented 1 year ago

According to https://ja.wikipedia.org/wiki/%E4%B8%83%E4%BA%94%E4%B8%89 this is an annual event celebrated in Japan. As not being a public holiday we use the type "observance" in this library to mark it as this type of event. If you still think that this is wrong please name a source to adjust or delete the event. Please consider reopening the PR.