commenthol / date-holidays

worldwide holidays
https://commenthol.github.io/date-holidays/
Other
906 stars 234 forks source link

Readme bundling with webpack detailing functionality lost #389

Open mcshaz opened 1 year ago

mcshaz commented 1 year ago

Thank you for this great library.

The Bundling with webpack header in the readme states it is worthwhile excluding astronomia and moment/locale dependencies from the build to minimise build size.

Would it be possible to add a couple of lines either in plain text or as comments in the example webpack config as to the downstream effects. For example something like (and clearly I have no idea of the consequences of excluding these 2 dependencies):

// exclude astronomia unless you need to support ???Turkish or ?? holidays
// excluding moment locale will mean all start and end date-times are given in local times on the computer running this library