Mark "Frauentag" as a public holiday for Berlin

commenthol / date-holidays

worldwide holidays

https://commenthol.github.io/date-holidays/

Other

918 stars 238 forks source link

Mark "Frauentag" as a public holiday for Berlin #414

Closed MaherSaleem closed 1 year ago

MaherSaleem commented 1 year ago

After 2019, Frauentag is considered as a public holiday in Berlin

commenthol commented 1 year ago

Hi @MaherSaleem, 8th of March is already a public holiday in Berlin. What do you intent with your change?

MaherSaleem commented 1 year ago

Hi @MaherSaleem, 8th of March is already a public holiday in Berlin. What do you intent with your change?

Hi @commenthol, I just added the name to be Frauentag (since now it's just called "03-08". Moreover, I've added type: public since it's a public holiday.

We use a system to fetch the public holidays for a specific city and our system is ignoring this since it doesn't have the type: public flag

arkraft commented 1 year ago

Hi,

the day is already a public holiday:

Also, _name is translated in a different file. The name is not "03-08", it is just the key for the reference in this file data/names.yml