commenthol / date-holidays

worldwide holidays
https://commenthol.github.io/date-holidays/
Other
907 stars 234 forks source link

Inconsistencies in classification of Dutch public holidays #434

Closed ehoogeveen-medweb closed 8 months ago

ehoogeveen-medweb commented 8 months ago

I noticed that Goede vrijdag (Good Friday) is marked as a public holiday, but Bevrijdingsdag (Liberation Day) is not.

Both are official public holidays:

However, not everyone is entitled to a free day on the following public holidays (unfortunately I think these pages are only available in Dutch):

So I'm not entirely sure how they should be classified within date-holidays, but if Liberation Day is optional then Good Friday should probably be optional as well.

commenthol commented 8 months ago

Hi @ehoogeveen-medweb ,

The definitions of holidays can be found in https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#types-of-holidays

For optional holidays where only "special" groups are entitled to enjoy them, I'd recommend to add a note stating that "constraint". I'd appreciate if you could file a Pull-Request on the findings you have made.