search

commenthol / date-holidays

worldwide holidays
https://commenthol.github.io/date-holidays/
Other
918 stars 238 forks source link

Remove Lovers' day from BR holidays #478

Open CarlaTeo opened 3 months ago

CarlaTeo commented 3 months ago

Lovers' Day was never a holiday in Brazil. You can check the brazilian wiki page for Holidays: https://pt.wikipedia.org/wiki/Feriados_no_Brasil. There is no mention at all to June 12 (or 12 de Junho in portuguese).

commenthol commented 3 months ago

Hi @CarlaTeo, I can see here that the day is celebrated in Brazil https://en.wikipedia.org/wiki/Dia_dos_Namorados. Could it be that you might got confused by type: observance?
This according to the spec means it is not an official holiday but an "optional festivity with no paid day off". Like Mothers Day. Please check https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#types-of-holidays

CarlaTeo commented 3 months ago

Hi @CarlaTeo, I can see here that the day is celebrated in Brazil https://en.wikipedia.org/wiki/Dia_dos_Namorados. Could it be that you might got confused by type: observance? This according to the spec means it is not an official holiday but an "optional festivity with no paid day off". Like Mothers Day. Please check https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#types-of-holidays

Hi, @commenthol, thanks for your reply.

I interpreted "with no paid day off" as "a day off but without payment", which is not the case, it is not like employers ask you if you want to take the day off. You can take the day off and not receive payment like any other day in the year. However, if it means just "a day of celebrations without a day off" it indeed is.

If it is the second, I'll just close the PR, even though I think some brazilian devs are having trouble because this is the only brazilian observance registered in this repo that not falls in a weekend, meaning that if you just 'getHolidays' without specifying the type, you can get all the days off with exception of Lover's day, which is not a day off. 😅