search

commerceblock / ocean-wallet

CB Electrum wallet implementation
MIT License
3 stars 3 forks source link

Unlimited Token Burns to Burnlisted address #77

Open cryptopoly opened 5 years ago

cryptopoly commented 5 years ago

Once a user has completed the redemption process by burning their tokens via a burnlisted address, the address remains on the burnlist and it's possible to send unlimited tokens to that address - even if not associated with the redemption. So these tokens will be unrecoverable.

Easy solution would be for the Controllers to blacklist the address as part of the redemption closure procedure.

The address label also still says "Frozen for redemption" so could probably say "Burn address - do not send tokens here" upon completing standard redemption process.

nkostoulas commented 5 years ago

Fair point. Controllers should probably remove the freezelisted and burn listed addresses.

The user should be responsible for changing the address label.