search

commerceguys / addressing

A PHP addressing library, powered by CLDR and Google's address data.
MIT License
922 stars 135 forks source link

Update Address Format for Russia #118

Closed lukasvs closed 1 year ago

lukasvs commented 5 years ago

Right format address for Russia

MyMarvel commented 5 years ago

Hey, can somebody commit it please? I stubled into this issue too and spent a lot of time trying to solve it. Thank you for the PR! Please, commit.

bojanz commented 4 years ago

Sorry for the delay everyone. Here's a review.

I approve of the idea to enable %additionalName for RU. 1) Should we do the same for BY and UA? 2) Why are we using %familyName %givenName %additionalName instead of %givenName %additionalName %familyName? Wikipedia doesn't list Russia as a country that leads with the family name (like Hungary and China do), maybe you have a resource you can link to?

lukasvs commented 4 years ago

As a rule, in Russia (I don't know exactly about Ukraine and Belarus) there is even an abbreviation as FIO (ФИО). When addressing a person, it doesn't matter what comes first: first or last name. But in most forms or docs that are filled out, the last name comes first. This is an established best practice.

lukasvs commented 3 years ago

Can somebody commit it please?

mvdve commented 2 years ago

Same for the Netherlands (NL) Lots of middle names here.

bojanz commented 1 year ago

Thank you for your patience, everyone.

Fixed via https://github.com/commerceguys/addressing/commit/0e0ab2b7e8c77c4bf60a9b1f662c1847cc978db0

Quoting the commit message:

The address formats for Belarus (BY), Kazakhstan (KZ), Russia (RU), Ukraine (UA)
now use the "%familyName %additionalName %givenName" field order,
as discussed in https://github.com/commerceguys/addressing/pull/118
and as evident in UPU's examples:
- https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/blrEn.pdf
- https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/kazEn.pdf
- https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/rusEn.pdf
- https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/ukrEn.pdf

The address formats for Azerbaijan (AZ), Bulgaria (BG), Uzbekistan (UZ) retain
the givenName / familyName order but with the patronymic field added
in between: "%givenName %additionalName %familyName".
This matches the UPU examples:
- https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/bgrEn.pdf
- https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/azeEn.pdf
- https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/uzbEn.pdf
And is backed by Wikipedia:
- https://en.wikipedia.org/wiki/Bulgarian_name
- https://en.wikipedia.org/wiki/Azerbaijani_name

Additional notes: