search

commerceguys / addressing

A PHP addressing library, powered by CLDR and Google's address data.
MIT License
922 stars 135 forks source link

Add subdivision for Paraguay #131

Closed jaranetwork closed 1 year ago

bojanz commented 4 years ago

Please open an issue at https://github.com/google/libaddressinput/issues requesting this change. Once it is added upstream, it will be automatically pulled into this library.

bojanz commented 1 year ago

We no longer need to wait for Google (we've disconnected from their formats), so we can proceed with this.

Looks like we need to set the administrative_area_type to "department". The field is optional (as already done in the MR).

Question: Should the format be "%postalCode %locality, %administrativeArea" (with a comma) as shown on https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/pryEn.pdf

On the other hand, UPU has the same format (with a comma) for Uruguay and our address format is comma-less ("%postalCode %locality %administrativeArea").

jaranetwork commented 1 year ago

It can also be used separated with a comma as shown in UPU just like Uruguay uses department.

bojanz commented 1 year ago

Committed in a10be69de4aaad6b096d6123e3d5a70d63793897, thanks!