search

commerceguys / addressing

A PHP addressing library, powered by CLDR and Google's address data.
MIT License
922 stars 135 forks source link

Philippines subdivisions #155

Closed interDist closed 1 year ago

interDist commented 3 years ago

During 2019, an array of changes in the provinces in Philippines was introduced. Various provinces were renamed (e.g., Compostela Valley to Davao de Oro). Since the PH.json file was last updated in 2018, it now contains incorrect data.

bojanz commented 3 years ago

You will want to open a bug report at https://github.com/googlei18n/libaddressinput/issues, our dataset is automatically generated from Google's endpoint. Once they make the change, it will be pulled into this library.

If you describe the suggested data changes in the issue you open, we can try to apply them in our library_customizations.php file.

I've looked at https://www.iso.org/obp/ui/#iso:code:3166:PH but I don't see Bangsamoro there, only the COM rename (Compostela Valley => Davao De Oro).

interDist commented 3 years ago

PH-14 was also renamed officially to Bangsamoro Autonomous Region in Muslim Mindanao or Bangsamoro in short, but since the library does not use region names, I removed its mention from the issue description.

These provinces (in addition to Compostela Valley) were also renamed: Mindoro Occidental to “Occidental Mindoro” and Mindoro Oriental to “Oriental Mindoro” ¯\_(ツ)_/¯

bojanz commented 3 years ago

https://www.iso.org/obp/ui/#iso:code:3166:PH still shows Mindoro Occidental and Mindoro Oriental. Is there another link you are using for your list? Would be good to reference it on the Google issue.

interDist commented 3 years ago

Updated the issue for Google's library. Official publications of PH Govt use these two names, e.g. https://psa.gov.ph/classification/psgc/downloads/SUMWEBPROV-SEPT2020-CODED-HUC-FINAL.pdf.