commerceguys / addressing

A PHP addressing library, powered by CLDR and Google's address data.
MIT License
922 stars 135 forks source link

Remove Jarvis Bay from Australias state list #159

Closed digcat closed 3 years ago

digcat commented 3 years ago

As nice as Jervis Bay is as a place, it isnt a state or territory in Australia. Please can we have this removed. thanks.

bojanz commented 3 years ago

You are modifying auto-generated code. You need to open an issue at https://github.com/google/libaddressinput/issues detailing what change you want made and why. Once Google makes it, we'll pull it in.

If no change happens within the next few weeks we can add a library override in https://github.com/commerceguys/addressing/blob/master/resources/library_customizations.php#L3

digcat commented 3 years ago

Ah sorry, guess that was too easy. Apologies. I can see Jarvis Bay coming from https://www.gstatic.com/chrome/autofill/libaddressinput/chromium-i18n/ssl-address/data/AU Which I assume is from the post office.

https://github.com/google/libaddressinput/issues/210

ok this is more complex, https://en.wikipedia.org/wiki/Jervis_Bay_Territory so although I guess it is correct, it isnt as far as Australians selecting a state from a drop down list.

digcat commented 3 years ago

will raise as an issue, looks like need to use sub_isoids key to derive correct list of states for AU