commerceguys / guzzle-oauth2-plugin

Provides an OAuth2 plugin (subscriber) for Guzzle
MIT License
123 stars 71 forks source link

Guzzle 6 #19

Open CDyWeb opened 9 years ago

CDyWeb commented 9 years ago

Please make this library compatible with Guzzle version 6

ip512 commented 9 years ago

:+1:

djfurman commented 9 years ago

:+1:

santiph commented 9 years ago

:+1:

spinx commented 9 years ago

:+1:

nicekiwi commented 9 years ago

:+1:

ldiebold commented 9 years ago

:+1:

obarcelonap commented 9 years ago

:+1:

frankkessler commented 8 years ago

I have the code working here with Guzzle 6, but I haven't had time to update the unit tests and really clean it up: https://github.com/frankkessler/guzzle-oauth2-plugin

GhazanfarMir commented 8 years ago

I still get this

commerceguys/guzzle-oauth2-plugin v2.1.0 requires guzzlehttp/guzzle ~5.0 -> no matching package found 

with following composer configuration:

"require": {
    "guzzlehttp/guzzle": "^6.1",
    "commerceguys/guzzle-oauth2-plugin": "~2.0"
  }
RomeroMsk commented 8 years ago

:+1:

fabpot commented 8 years ago

ahah, first time I'm going to do something I hate to see people doing on my repositories, sorry guys, :+1:

pjcdawkins commented 8 years ago

The direction my thoughts are going in is to remove almost all the code dealing with OAuth2... and just provide a middleware, to link this existing oauth2 library with Guzzle 6+:

https://github.com/thephpleague/oauth2-client

liverbool commented 8 years ago

:+1:

vzailskas commented 8 years ago

:+1:

lemasson-h commented 8 years ago

I created a pull request to have it working with guzzle 6: https://github.com/commerceguys/guzzle-oauth2-plugin/pull/29. If you could let me know what you think about it, that would be great. :)

mathielen commented 8 years ago

:+1:

geekdevs commented 8 years ago

@pjcdawkins I agree what you say about switching this to middleware. I even found some for the good start (https://github.com/gsomoza/oauth2-middleware).

The problem is that it basically means implementations would need to be re-created to support Guzzle 6 then. Currently I some library I'd like to use which uses Guzzle 6, but cannot because this guzzle-oauth2-plugin is Guzzle 5 and thus conflicts with v.6.

So I am looking forward to get that PR merged! I think I'm not alone in that issue.

pau1m commented 8 years ago

👍

guiyomh commented 8 years ago

:+1:

zazoomauro commented 7 years ago

👍

august-9426 commented 7 years ago
dunglehome commented 7 years ago

tested working like charm and can not be easier https://github.com/dunnleaddress/oauth2-client