search

commerceguys / tax

A PHP 5.5+ tax library.
MIT License
275 stars 39 forks source link

Critical enddate comparison fix #56

Closed el-seirh closed 6 years ago

el-seirh commented 6 years ago

There was an issue in the TaxRate models getAmount-function. When matching the date against the end dates the > operator was used instead of >=. This led to a behaviour where any date that exactly matched any periods end date would not return a tax rate.

bojanz commented 6 years ago

Good catch. Could you rebase to remove the commits that are already in master?

el-seirh commented 6 years ago

Hi @bojanz To keep it simple i created another pull request https://github.com/commerceguys/tax/pull/57 without the other commits.