search

commerceguys / tax

A PHP 5.5+ tax library.
MIT License
276 stars 39 forks source link

Critical enddate comparison operator fix #57

Closed el-seirh closed 6 years ago

el-seirh commented 6 years ago

There was an issue in the TaxRate models getAmount-function. When matching the date against the end dates the > operator was used instead of >=. This led to a behaviour where any date that exactly matched any periods end date would not return a tax rate.

bojanz commented 6 years ago

That's still broken. Your local master is not up to date (git checkout master && git pull origin master) Once you update master you can switch back to your PR branch and do a "git rebase master" to rewind.

el-seirh commented 6 years ago

I'm gonna close this one again since I have been able to correctly sync my forks master but failed to correctly rewind my PR branch.

el-seirh commented 6 years ago

@bojanz I created a new PR https://github.com/commerceguys/tax/pull/58. Sorry for the inconvenience. II hope the latest PR is ok.