Closed el-seirh closed 6 years ago
@bojanz Hi there. This time everything sould be correct I think. Do you think you could merge in the close future? Then I could use your master again. Thanks!
@bojanz Bump. Is there any reason not to merge? I'd be glad to help. This fix is pretty critical.
bump
@bojanz Still waiting for that merge ;).
I'm back! And terribly sorry.
@bojanz No worries. Glad I could be of help. Thanks for merging!
There was an issue in the TaxRate models getAmount-function. When matching the date against the end dates the > operator was used instead of >=. This led to a behaviour where any date that exactly matched any periods end date would not return a tax rate. This fix makes sure enddates themselves are included in a tax period.