Improving the support for "display_inclusive"

commerceguys / tax

A PHP 5.5+ tax library.

MIT License

275 stars 39 forks source link

Improving the support for "display_inclusive" #67

Closed pavkatar closed 4 years ago

pavkatar commented 5 years ago

Currently all tax_types are with display_inclusive: true, which is not correct and can not depend on this logic. For example, in Finland the prices should be shown without taxes, but in the fi_vat.json it is hardcoded: "display_inclusive": true,

bojanz commented 5 years ago

Improve how? When are Finland's prices not tax inclusive by default? The point of the flag is to provide a reasonable default, not cover every possible case. And with VAT prices generally are price inclusive.

bojanz commented 4 years ago

No reply given.