commerceguys / tax

A PHP 5.5+ tax library.
MIT License
276 stars 39 forks source link

Intra-Community should look at the tax zones instead of countries #71

Open pjcarly opened 4 years ago

pjcarly commented 4 years ago

Currently the decision whether the Intra-Community TaxType should be used is decided on the country of the Customer and the country of the Store. If they are both within the EU but are different from each other IC can be used.

https://github.com/commerceguys/tax/blob/master/src/Resolver/TaxType/EuTaxTypeResolver.php#L71

However I believe this to be incorrect. I think the IC should be decided on the zones of the addresses. For example:

A store registered in Vienna, Austria should use IC when charging a customer with a VAT number and an address in Mittelberg, Austria (because Mittelberg is an exception and falls under German VAT). However, a store registered in Berlin, Germany should charge regular German tax for that same customer.

Or am I incorrect?

pjcarly commented 4 years ago

I checked this with our accounting department, and according to them, my suspicion is correct.

bojanz commented 4 years ago

That makes sense to me, thanks for confirming.

pjcarly commented 4 years ago

If I can find some time i'll make a PR.