In #69 and #76 we've added performance measurements. They currently communicate the performance metrics using a shared structure performance_records = [] and also the result is ignored by the caller in tests/performance_comparison.py.
If the returned result isn't valuable as indicated by this line, why are we returning it? _ = measure_performance(test_runner_function, clone_dir)
let's also return the performance_records directly rather than having code coupled with a shared data structure (which then needs re-initialising each time that measure_performance(...) is called.
Context
In #69 and #76 we've added performance measurements. They currently communicate the performance metrics using a shared structure
performance_records = []and also the result is ignored by the caller intests/performance_comparison.py._ = measure_performance(test_runner_function, clone_dir)measure_performance(...)is called.