search

commercetools / commercetools-api-reference

commercetools API reference documentation
http://docs.commercetools.com/
57 stars 27 forks source link

Missing Scalars in GraphQL SDL file #282

Closed NullScope closed 1 year ago

NullScope commented 1 year ago

According to the docs this file should be used for development and production usage, however when we try to use buildSchema from graphql package, it errors out because it's missing both Long and BigDecimal scalars.

If we add these two scalars into the file, the schema is built successfully, an example can be found here on replit (keep in mind it might take a while to load)

jenschude commented 1 year ago

I reported it to the respective team. For now the only workaround is as you did to extend the file with these missing types

NullScope commented 1 year ago

Thank you @jenschude, when this SDL file gets fixed, will we be notified in advance before it gets published here? I ask because if it gets fixed without warning while we are extending the file ourselves, it will cause the buildSchema to throw errors as well

jenschude commented 1 year ago

Once it's fixed it will be automatically updated in the main branch. If you want to prevent a failing build you could point to the permalink of the file

NullScope commented 1 year ago

Hi @jenschude, any updates on this issue?

NullScope commented 1 year ago

Hi, I can see its already been added on this commit on June 19th, I'll close this issue now