search

commercetools / commercetools-jvm-sdk

The e-commerce SDK from commercetools running on the Java virtual machine.
https://commercetools.github.io/commercetools-jvm-sdk/apidocs/index.html
Other
62 stars 40 forks source link

Evaluate removal of async-http-client versions #1411

Open katmatt opened 7 years ago

katmatt commented 7 years ago

Based on the actually used async-http-client versions - which should be sent as part of the user-agent header - we could consider to remove support for async-http-client from our SDK.

acbeni commented 7 years ago

@katmatt do you mean removing sdk-http-ahc-1_8, sdk-http-ahc-1_9 ... ? they are no longer used, and i think we can safely remove them. WDYT?

katmatt commented 7 years ago

@acbeni Yes, I was mainly thinking about the sdk-http-ahc-1_ clients. But we should take a look at our request logs and analyze the http clients are still used by our users. Based on the results we can then decide which clients could be removed.