Fix redundant SphereClient initialization - Githubissues

commercetools / commercetools-payment-integration-java

Module to handle payment transactions

Apache License 2.0

6 stars 4 forks source link

Fix redundant SphereClient initialization #60

Closed andrii-kovalenko-ct closed 6 years ago

andrii-kovalenko-ct commented 6 years ago

[ ] Remove sphere client instantiations from the library, the client should be injected

https://github.com/commercetools/commercetools-payment-integration-java/blob/b8d1fab9b3e3efdb82b6f32c5ff964085953cdb2/common/src/main/java/com/commercetools/payment/utils/impl/PaymentConnectorHelperImpl.java#L24
- [ ] looks like in this class (PaymentConnectorHelperImpl) sphere client is redundant, HttpClient should be enough

andrii-kovalenko-ct commented 6 years ago

Wrong