Fix unexpected Paypal Plus payment execution state - Githubissues

commercetools / commercetools-paypal-plus-integration

Integration between commercetools API and PayPal Plus API

Apache License 2.0

7 stars 1 forks source link

Fix unexpected Paypal Plus payment execution state #113

Open andrii-kovalenko-ct opened 6 years ago

andrii-kovalenko-ct commented 6 years ago

PayPal Plus pending state is unexpected:

https://github.com/commercetools/commercetools-paypal-plus-integration/blob/cbfd648cddc38ef65e373fc3bf8d4ec103a7142c/src/main/java/com/commercetools/pspadapter/paymentHandler/impl/PaymentHandler.java#L274-L282

Expected only: state:

created. The transaction was successfully
approved. The buyer approved the transaction.
failed. The transaction request failed.

See:

https://developer.paypal.com/docs/api/payments/#payment_execute
com.paypal.api.payments.Payment#getState() doc

Implementation guides:

[ ] remove PaypalPlusPaymentStates#PENDING reference and all it's usages
[ ] add PaypalPlusPaymentStates#FAILED handling case