commercetools / commercetools-paypal-plus-integration

Integration between commercetools API and PayPal Plus API
Apache License 2.0
7 stars 1 forks source link

127 mock integration test configs #130

Closed andrii-kovalenko-ct closed 6 years ago

andrii-kovalenko-ct commented 6 years ago

Mock heavy redundant executions in the integration tests:

andrii-kovalenko-ct commented 6 years ago

https://github.com/commercetools/commercetools-paypal-plus-integration/pull/130#discussion_r183025943

something about this class that I noticed (not related to this pr), why is the tenantNameToWebhookCompletionStage instance variable a CompletableFuture<Map<String, Webhook>> and not just a CompletableFuture<Set> since I see an implementation for such a composite object already?

@heshamMassoud i think because of getWebhookCompletionStageByTenantName() function.

But what @lojzatran could you say?