129 error prone plugin - Githubissues

commercetools / commercetools-paypal-plus-integration

Integration between commercetools API and PayPal Plus API

Apache License 2.0

7 stars 1 forks source link

129 error prone plugin #135

Open andrii-kovalenko-ct opened 6 years ago

andrii-kovalenko-ct commented 6 years ago

Apply google error prone plugin
fix found error prone issues:
- put missing keywords (@Override, final, synchronize etc)
- make WebhookWithTenantName as a static inner class since it doesn't require instance context
- remove getByPaymentMethodAndInterfaceId() (never used or tests and implemented with infinite recursion)
- use explicit default charset in the application
- (the best one!) fixed incorrect test assertion, which actually tested nothing because of wrong brace ) place!