search

commercetools / commercetools-paypal-plus-integration

Integration between commercetools API and PayPal Plus API
Apache License 2.0
7 stars 1 forks source link

[Urgent] Don't override payment reference custom field! #136

Open andrii-kovalenko-ct opened 6 years ago

andrii-kovalenko-ct commented 6 years ago

If returned payment from PayPal service request contains paymentInstruction - the CTP payment custom field reference will be overridden: https://github.com/commercetools/commercetools-paypal-plus-integration/blob/cbfd648cddc38ef65e373fc3bf8d4ec103a7142c/src/main/java/com/commercetools/pspadapter/paymentHandler/impl/PaymentHandler.java#L336

BUT this field is set by front-end and is a mandatory reference to an order, so must be untouched!

Pls, fix it ASAP. Guess we have to introduce new optional custom filed smth like paymentInstructionReferenceNumber for this purpose.

butenkor commented 5 years ago

@lojzatran Any notes on the issue?

lojzatran commented 5 years ago

No comment from me.