Include params in cache key

commercetools / commercetools-php-symfony

MIT License

10 stars 6 forks source link

Include params in cache key #76

Open markus-mw opened 3 years ago

markus-mw commented 3 years ago

The cacheKey in getCategories method is lacking the params array. There should be added something like this:

$cacheKey = static::CATEGORIES_NAME . '-' . $locale . md5(serialize($params));

https://github.com/commercetools/commercetools-php-symfony/blob/71ca1b8940262ae0f98d46a6bdf694bde78973aa/src/CatalogBundle/Model/Repository/CatalogRepository.php#L278

jenschude commented 3 years ago

Hi,

we are atm not actively working on this package. In case you need the functionality soon you could fork the repository or copy/extend the specific class according to your needs.