CompatSphereClient clientConfig.getCorrelationIdGenerator() not public/accessible with SDKV1 < 2.**

[pintomau]

Describe the bug SphereClientConfig#getCorrelationIdGenerator is package-private in SDKV1 <2, and public in SDKV1 >=2. CompatSphereClient breaks for versions lower than 2 due to calling the above method when using SDKV1 <2.

To Reproduce Create a CompatSphereClient while depending on SDK V1 lower than 2 and trigger a request.

Observe the error:

CompatSphereClient tried to access method 'io.sphere.sdk.client.CorrelationIdGenerator io.sphere.sdk.client.SphereClientConfig.getCorrelationIdGenerator()'

Expected behavior An alternative path for SDKV1 lower than V2.

Screenshots/Code snippet If applicable, add screenshots or code samples to help explain your problem.

Stack information (please complete the following information):

• Java: 11
• SDK1: 1.64 via commercetools-sync-java 8.0.0
• SDK2: 7.3

Additional context

Possible mitigation: the class is simple enough that just copying and removing the line should be enough. We decorate the client to produce the correlation id, so we expect no impact by doing so.

[jenschude]

Just released a 1.64.2 which makes the CorrelationIdGenerator interface public

Edit: directly saw my mistake 🤦‍♂️ The config method will also be opened

[jenschude]

And 1.64.3 released which backports the changes from the 2.0 release

[pintomau]

Hey @jenschude , thanks a lot for the changes!

Can we expect a minor on the Sync to bump these versions as well or would we need to override them for now?

[jenschude]

I'm not involved in the sync library. So you have to ask there or just override it