Closed pintomau closed 7 months ago
For the api module a special HttpExceptionFactory is initialized here:
The reason is that for api.
I see. We're indeed using ClientBuilder with ProjectApiRoot#fromClient instead of ApiBuilder.
Adding that factory, works.
Btw the unwrap completion exception flag is useful if the future should directly throw the exception in the error case. Which saves the check for the completionexceptions cause
Yeah, if I had noticed sooner, I'd use it. We took care of it in a different way. Will consider refactor. Thanks
Hi.
Maybe more of a clarification.
I've noticed RetryHandler (https://github.com/commercetools/commercetools-sdk-java-v2/pull/385/files), but it is looking only for a specialized instance of ConcurrentModificationException (com.commercetools.api.client.error.ConcurrentModificationException instead of io.vrap...).
Am I using this wrong, do we need to use UNWRAP_COMPLETION_EXCEPTION?
Do you think creating our own RetryHandler based on io.vrap...ConcurrentModificationException would solve this, or is there something I'm missing?