search

commercetools / commercetools-sdk-java-v2

The e-commerce SDK from commercetools for Java.
https://commercetools.github.io/commercetools-sdk-java-v2/javadoc/index.html
Apache License 2.0
35 stars 16 forks source link

Dependency on commons-io:commons-io:2.17.1-SNAPSHOT #734

Closed ronaldtb closed 1 hour ago

ronaldtb commented 2 hours ago

In our projects we are updating the com.commercetools.sdk:commercetools-http-client dependency to 17.15.1 and are running into the issue that the transitive dependency com.commercetools.sdk:commercetools-async-http-client:17.15.1 depends on commons-io:commons-io:2.17.1-SNAPSHOT that can't be found in the public Maven repositories.

Can this maybe be changed to a non-SNAPSHOT version?

jenschude commented 2 hours ago

The SDK is not pulling a snapshot version, it refers to 2.11.0 of commons-io.

https://github.com/commercetools/commercetools-sdk-java-v2/blob/2e4c00a8799c5104b0c237c05a0ad1035a6dbde4/commercetools/commercetools-async-http-client/build.gradle#L5

https://github.com/commercetools/commercetools-sdk-java-v2/blob/2e4c00a8799c5104b0c237c05a0ad1035a6dbde4/gradle-scripts/extensions.gradle#L19-L22

https://github.com/commercetools/commercetools-sdk-java-v2/blob/2e4c00a8799c5104b0c237c05a0ad1035a6dbde4/licenses/index.json#L539-L551

The AHC dependency depends on commons-io 2.6.

So it may be that the dependency tree on your side resolves it incorrectly.

ronaldtb commented 1 hour ago

Thanks for the quick response, it seems this was caused by <snapshots><enabled>true</enabled></snapshots> in my Maven settings.xml for the proxy in combination with the [2.8.0,) version.