Closed lojzatran closed 2 months ago
Latest commit: ab80939a060c13fa056136077cd5fea1e94215c4
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.07%. Comparing base (
a4fcf87
) to head (ab80939
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @lojzatran, can we get a description of what this PR or maybe what it is trying to achieve? Thanks
Hi @lojzatran, can we get a description of what this PR or maybe what it is trying to achieve? Thanks
Hi @ajimae, I added the description.
There was an issue that more than 1000 product types were created. This is the limit of CTP: https://docs.commercetools.com/api/limits#product-types. So, we need to ensure that the product type is created only if it does not exist. This PR checks if the product type exists before creating a new one.