search

commercetools / commercetools-sunrise-java-cms

Module for Sunrise Java to use CMS
Apache License 2.0
1 stars 2 forks source link

Update contentful code for new service interface #11

Closed dariuszor closed 8 years ago

dariuszor commented 8 years ago

@lauraluiz @schleichardt Could you have a look? I've updated code to meet new requirements. I am updating README.md file.

lauraluiz commented 8 years ago

Besides the comment, I think the rest is good to go 👍

dariuszor commented 8 years ago

@lauraluiz so I will merge. Should I assign PR to you when I am updating PR according to your comments, like I did before?

I am planning to integrate this service to my sunrise project. It has every functionality which are required for now.

lauraluiz commented 8 years ago

@dariuszor sorry, the update was fine.

Regarding to Sunrise, I am currently updating the Cms behaviour from it. You won't be able to use it until I finish. I plan on finishing the changes today, then I'll create a snapshot version you can use.

floriansattler commented 8 years ago

@lauraluiz did you update the CMS behaviour already? Please let us know when it's finished.

lauraluiz commented 8 years ago

@dariuszor the new CMS structure is being used in Sunrise already, with version 0.8.2-cms-update-SNAPSHOT. In order to use CMS from a controller, you have to implement the interface WithCmsPage. It is used already in HomeController, if you want an example.

Regardless of that, an open issue is that this CMS service is not being released yet and the common stuff needs to be removed from one of the sides (now we have 2 CmsService and so on). Are you guys working on some temporary solution for that already or are you expecting us to do this part?

floriansattler commented 8 years ago

@lauraluiz we haven't been working on a temporary solution here yet and would expect you guys to do that. Until when could you finish it?