Decide how to handle controllers with only form

commercetools / commercetools-sunrise-java

The next generation shop framework by commercetools

https://demo.commercetools.com

Apache License 2.0

46 stars 35 forks source link

Decide how to handle controllers with only form #619

Closed lauraluiz closed 7 years ago

lauraluiz commented 7 years ago

Associate content or just redirect? It might affect showing error messages, but should stay in flash during redirect.

lauraluiz commented 7 years ago

Also it disables the possibility to pre-fill the form.

lauraluiz commented 7 years ago

But on the other side it doesn't link the form to any page, which will give it more freedom to be used on many places.

lauraluiz commented 7 years ago

Redirect:

Hides POST URLs in case it doesn't have a GET counterpart.
Does not require an associated content.

Non-redirect:

Keeps form content from user.
Straightforward to show errors on form.
Allows to return an error status code, i.e. 400.

lauraluiz commented 7 years ago

Non-redirect is the way Play supports. To solve issue with POST URLs we can have a always GET counterpart for the same URL which redirects to the show form controller action.

lauraluiz commented 7 years ago

Possible solutions:

Have a show method on each of the process controllers that redirects to the form page (additional redirection).
Have GET/POST route pairs (multiple URLs to same content can raise SEO issues).
Use AJAX (additionally we can then use PUT/DELETE for a cleaner REST-ful routes style).

None of the solutions is completely satisfactory or realistic at the moment.