search

commercetools / commercetools-sunrise-java

The next generation shop framework by commercetools
https://demo.commercetools.com
Apache License 2.0
46 stars 35 forks source link

Settings for client product and categories #663

Closed lauraluiz closed 6 years ago

lauraluiz commented 6 years ago

So I decided to split the big stale branch that I had with configuration improvements into new and smaller PR. First one is just simply unify everything under "CTP", i.e. client, categories and products configuration.

I will put some comments in the PR.

lauraluiz commented 6 years ago

@katmatt I've searched for all occurrences of CategoriesSettings and ProductAttributesSettings and corrected all names. Thanks for reporting it! 👍

lauraluiz commented 6 years ago

Damn, I'm not sure how I missed that one after looking at each one of the occurrences :( But luckily you have good eye! :D One more try, I hope this time you don't find any @katmatt ;)

lauraluiz commented 6 years ago

Yay! 🎉