search

commercetools / commercetools-sunrise-java

The next generation shop framework by commercetools
https://demo.commercetools.com
Apache License 2.0
46 stars 35 forks source link

Adding reset password confirmation page #666

Closed acbeni closed 6 years ago

acbeni commented 6 years ago

Closes #651

acbeni commented 6 years ago

I now added all the recovery password mechanisms in one controller RecoverPasswordController.

WDYT about it @lauraluiz ?

acbeni commented 6 years ago

@lauraluiz i made some changes, what do you think about it now?

acbeni commented 6 years ago

@lauraluiz it looks good to me 👍 now its much better and the messages can be used for more general purposes 🥇 If you think its good enough you can approve my changes ( 😅 since i am te one who started the PR i can't accept your changes) as of then i can update the theme to support the new feature.

acbeni commented 6 years ago

@lauraluiz i updated the theme version, and deleted the temporary files, tested sunrise locally and it all seems good 👍 guess we'll merge the changes.

lauraluiz commented 6 years ago

Yep, it does look good! You can merge changes if you want :)