search

commercetools / commercetools-sunrise-java

The next generation shop framework by commercetools
https://demo.commercetools.com
Apache License 2.0
46 stars 35 forks source link

Accept i18n errors #684

Closed lauraluiz closed 7 years ago

lauraluiz commented 7 years ago

All error messages can be localized now. The ones defined in Sunrise are located in the bundle "messages" (as shows the messages.yaml files). The ones pre-defined by Play (i.e. https://github.com/playframework/playframework/blob/2.5.18/framework/src/play/src/main/resources/messages.default) are located in the default bundle ("main" if not changed). They can also be localized using the default Play way of creating messages files for each language.

acbeni commented 7 years ago

@lauraluiz i like what has been done in general, there is major quality amelioration that can be done and that i think is worth the effort, which is to work with generated classes like the android R.java which would allow us to get hold of all the messages in type safe way.

WDYT?

lauraluiz commented 7 years ago

Having type-safe messages sounds really interesting @acbeni ! I hadn't thought of that solution. Could you please create an issue for that? I would address that after v1.0.0 though.

lauraluiz commented 7 years ago

And actually all theme resources might benefit from it.

acbeni commented 7 years ago

@lauraluiz i created issue to follow up #685