search

commercetools / commercetools-sunrise-java

The next generation shop framework by commercetools
https://demo.commercetools.com
Apache License 2.0
46 stars 35 forks source link

Cart discount code #686

Closed katmatt closed 6 years ago

katmatt commented 6 years ago

Closes #674

katmatt commented 6 years ago

@lauraluiz May be we should add an example cart discount with some discount codes to https://github.com/commercetools/commercetools-sunrise-data ? Impex unfortunately doesn't support CartDiscount, which means that we have to create our own json import for them 😞 WDYT?

katmatt commented 6 years ago

@lauraluiz I've fixed all issues. Looking forward to your feedback 😄

katmatt commented 6 years ago

@lauraluiz I fixed the failing tests and changed the description in the discount code view model to LocalizedString. Looking forward to your feedback/approval 😉