commercetools / commercetools-sunrise-java

The next generation shop framework by commercetools
https://demo.commercetools.com
Apache License 2.0
46 stars 35 forks source link

Implementation PDP #87

Closed trangng closed 9 years ago

trangng commented 9 years ago

Implement PDP based on https://github.com/sphereio/sphere-sunrise-design/issues/2

lauraluiz commented 9 years ago

@trangng can you please list what are the MVP for this page? For example, do we have to implement wishlist, reviews, etc.?

lauraluiz commented 9 years ago

And how is the algorithm for the "You may also like" section?

lauraluiz commented 9 years ago

And when is a product available? When stock units > 0?

schleichardt commented 9 years ago

What means "Sunrise #SUN123456" in http://sphereio.github.io/sphere-sunrise-design/pdp.html# ? The second one is probably the SKU but what is the first one?

schleichardt commented 9 years ago

What should happen if I click "VIEW DETAILS" in http://sphereio.github.io/sphere-sunrise-design/pdp.html# ?

schleichardt commented 9 years ago

Idea: It scrolls to "PRODUCT DETAILS" and opens the accordion?

peter-gerhard commented 9 years ago

https://github.com/sphereio/sphere-sunrise-design/blob/master/input/templates/pdp.json#L965

what is the exact meaning of priceOld?

hajoeichler commented 9 years ago

If you have a product discount. You want to get the attention of the customer by showing 99.99 strikethrough and 79.99 as new price next to it.

schleichardt commented 9 years ago

still internal doc: https://sphere.atlassian.net/wiki/pages/viewpage.action?pageId=19333572

trangng commented 9 years ago

@lauraluiz @peter-gerhard MVP for PDP is everything except:

schleichardt commented 9 years ago

@trangng What is with inventory?

schleichardt commented 9 years ago

I think it would be better to have a whitelist what in this development step needs to be done.

trangng commented 9 years ago

algorithm for the "You may also like" section?: 4 products should be shown from

trangng commented 9 years ago

And when is a product available? Yes, when stock units > 0

trangng commented 9 years ago

What means "Sunrise #SUN123456" in http://sphereio.github.io/sphere-sunrise-design/pdp.html# ? This is the article number. So right text would be e.g.: "Article number CYBORG Z01"

trangng commented 9 years ago

What should happen if I click "VIEW DETAILS" in http://sphereio.github.io/sphere-sunrise-design/pdp.html# ? If customer clicks on "VIEW DETAILS" the full product description will be shown. Other wise only the first 2 lines.

trangng commented 9 years ago

Idea: It scrolls to "PRODUCT DETAILS" and opens the accordion?

No, under "PRODUCT DETAILS" we show the product attributes e.g.: Material: 60% viscose, 35% polyamide, 5% elastane One button on front Two patch pockets on front Front longer than back The model wears a size 38: Dry clean only

trangng commented 9 years ago

@schleichardt what do you exactly mean by inventory? the inventory import?

schleichardt commented 9 years ago

No, there is a green check mark and right next to it "Available", can we just hardcode it to always be on stock for now? Adding stock to logic makes not much more to see for demos right now but would kill much time.

schleichardt commented 9 years ago

There is no UI element for "VIEW DETAILS" to display further information.

JulianSamarjiev commented 9 years ago

@schleichardt I will add that, I wasn't sure myself what is the purpose of having so much text space and 2 accordions for displaying one product's information... @trangng feel free to add it as a task :)

trangng commented 9 years ago

No, there is a green check mark and right next to it "Available", can we just hardcode it to always be on stock for now?

@schleichardt ok you can hardcode it for now

peter-gerhard commented 9 years ago

@trangng is there a specification of how the prices should be formatted?

peter-gerhard commented 9 years ago

@trangng can you provide a product with multiple variants that differ in size and color, please?

currently there are a lot of products where the color is not represented in variants but in the product title, like [actual title] [color] see: https://admin.sphere.io/sunrise-staging/products/cfedbda7-55cf-4c1e-9e35-1378a0418c64

for the color and size chooser i need the products to use the model like intended.

peter-gerhard commented 9 years ago

"Quantity: you can insert a quantity up to 100 pieces. If there is an insufficient stock, you will get an error message" from https://sphere.atlassian.net/wiki/pages/viewpage.action?pageId=19333572

if its possible to select up to 100 pieces the selection box gets quite huge, because it tries fit as much choices on the screen as possible, just a minor design issue. for now i will limit the number to 10.

butenkor commented 9 years ago

@schleichardt Why adding stock logic to PDP would kill much time? Isn't just fetching inventories for given sku?

schleichardt commented 9 years ago

Sunrise is a demo shop, it is not visible by the outside world how much is in the imaginary stock.

butenkor commented 9 years ago

Your last statement sounds like a cryptic oracle forecast :) Could you elaborate why demo shop should not show availability infos and it would kill much time?

schleichardt commented 9 years ago

It is a demo shop, there is no (real) stock and availability.

butenkor commented 9 years ago

How are you going to show PDP if you have no real product and no real stock?

schleichardt commented 9 years ago

Just show the product data and hardcode that it is available.

butenkor commented 9 years ago

How are you going to add to cart if its not on stock?

schleichardt commented 9 years ago

The default cart does not check inventory:

butenkor commented 9 years ago

I think its wrong as we should use ReserveOnOrder by default and should always check if item is on stock before we allow the customer to add to it to a cart. As customer you do not want to make whole checkout process and pay for something which is not stock or even not available anymore. @trangng please check that and specify how we should proceed here.

peter-gerhard commented 9 years ago

"Size guide: if you click on the sizeguide a overlay with the measurements will be shown" @trangng how is this provided?

peter-gerhard commented 9 years ago

@trangng "Product Details" and "Delivery and Returns" are currently simple String types in pdp.json it would be nicer to show details and shipping methods as lists.

trangng commented 9 years ago

@peter-gerhard size guide was done by @JulianSamarjiev I'm not sure if he only have it local or it's not done yet. I'll ask him as soon as he's back from holiday

trangng commented 9 years ago

@peter-gerhard I'll talk to @JulianSamarjiev about the tabs "Product Details" and "Delivery and Returns"

schleichardt commented 9 years ago

@peter-gerhard In The future, can you include the issue number in the commit message, please? This way they will be shown here.

Example: Use Add sku prefix to ProductData. #87 instead of Add sku prefix.

schleichardt commented 9 years ago

@trangng @peter-gerhard When you want to quote something, then prefix it with > so it is easier to understand:

code:

> Idea: It scrolls to "PRODUCT DETAILS" and opens the accordion?

No, under "PRODUCT DETAILS" we show the product attributes e.g.:
Material: 60% viscose, 35% polyamide, 5% elastane

result:

Idea: It scrolls to "PRODUCT DETAILS" and opens the accordion?

No, under "PRODUCT DETAILS" we show the product attributes e.g.: Material: 60% viscose, 35% polyamide, 5% elastane

schleichardt commented 9 years ago

Create a new ticket for new questions with the pdp label, please.