commercetools / commercetools-sunrise-theme

Sunrise Theme from commercetools

http://commercetools.github.io/commercetools-sunrise-theme/site/en/home.html

13 stars 16 forks source link

Re-evaluate the css #336

Closed adnasa closed 7 years ago

adnasa commented 8 years ago

I think it is really time that we re-evaluate the css architecture in this project. It's more than a couple of time that I run into redundancy css, high specificity and that it is hard to get an overview over changes.

I suggest we take a look at atomic design

lauraluiz commented 8 years ago

@adnasa @trangng of course I won't go against it, it is something important to make the template maintainable in the future. Also it is necessary to establish some guidelines for future templates based on this one. I also found some problems when having to modify the template, so green light on my side. But who?

adnasa commented 8 years ago

yeah, let me see if I can find the time to work out something out soon. Added it to the backlog during the meantime.

lauraluiz commented 8 years ago

:+1:

lauraluiz commented 8 years ago

Specific improvements:

Rename color vars in _general.scss so that it follows a good naming convention (https://davidwalsh.name/sass-color-variables-dont-suck)
Have one global button style

adnasa commented 8 years ago

@lauraluiz yeah, I think it is a good idea to start small, work with making small changes with ATOM as the end goal and take it from there ;)

adnasa commented 8 years ago

366

adnasa commented 7 years ago

Closing this since there hasn't been any development in the past year on this issue